-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UP][m] Updating the scripts with v2 source of world bank #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gradedSystem ! Nice work, but lets remove this README in scripts
and merge it into README in root directory, all the contents move to Preparation
section as in https://github.com/datasets/currency-codes. Also include how to run make
file as in your github actions. Lets make a same structure. Also please remove some unnecessary headings such as Usage of process.py
and Tags and committing changes
and make it simple and easy to read.
@Mikanebu done |
README.md
Outdated
but please follow [OKFN's curator guide](http://data.okfn.org/doc/core-data-curators) | ||
to keep things as organized as possible. | ||
|
||
## Tags and committing changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this pls
README.md
Outdated
|
||
## License | ||
|
||
All data is licensed under the Open Data Commons Public Domain Dedication and License. All code is licensed under the MIT/BSD license. | ||
|
||
Note that while no credit is formally required a link back or credit to Rufus Pollock and the Open Knowledge Foundation is much appreciated. | ||
|
||
|
||
## Contributing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this one, since that url is not valid anymore
README.md
Outdated
@@ -7,9 +7,40 @@ The repository of the data package of the GINI Index. | |||
The data that is contained in the `gini-index.csv` file, under `/data` was | |||
retrieved from [the World Bank](http://data.worldbank.org/indicator/SI.POV.GINI). | |||
|
|||
## Requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should be Preparation
section and add some sentence on how to run scripts
README.md
Outdated
run the script. | ||
|
||
`pip install -r scripts/requirements.txt` | ||
|
||
|
||
## License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the license, add Automation
section as in https://github.com/datasets/gdp
Run the requirements through `pip` in order to install all required packages to | ||
run the script. | ||
|
||
`pip install -r scripts/requirements.txt` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after this add how to run script for example:
Process is recorded and automated in python script:
scripts/process.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done @Mikanebu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to make
pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add how to run script in Preparation
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your actions, it is make
to run script?
@Mikanebu Yes it is |
@gradedSystem Pls, update then accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes made
archive
anddata
folderscc @anuveyatsu